Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent CMake Tools activation when CMakeLists.txt is not in the workspace folder or at cmake.SourceDirectory #1167

Closed
andreeis opened this issue Apr 9, 2020 · 3 comments
Assignees
Milestone

Comments

@andreeis
Copy link
Contributor

andreeis commented Apr 9, 2020

Since CMake Tools changed the activation condition from CMakeLists.txt found in the root to anywhere inside the workspace, we get into situations when it activates for non CMake repos. One example is when a non CMake repo contains some tests that have CMake files.

Preventing the activation or programmatically deactivating the extension might not be possible, but at least we would like to disable the features until the state of the workspace changes (it becomes a real valid CMake repo).

Integrate this functionality with the message box asking about QuickStart or cmake.sourceDirectory, providing a third option, to ignore this folder.

@parched
Copy link

parched commented May 20, 2020

This looks great, thank you. It's not clear to me though if this is something I can set in setting.json. I would like to share share my multiroot workspace with my team and they not get the popup about missing CMakeLists at all. Will that be possible?

@bobbrow
Copy link
Member

bobbrow commented May 20, 2020

Not in 1.4.0. If you want to open a new issue to request we add a setting for it, we can consider doing that for a future release.

You can try out the experience today by installing the beta on our releases page

@andreeis
Copy link
Contributor Author

This fix is available in CMake Tools #1.4.0 which has been released.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants