Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It doesn't detect ninja-build as a valid alternative command for ninja #1

Closed
astitcher opened this issue Apr 18, 2016 · 1 comment
Closed

It doesn't detect ninja-build as a valid alternative command for ninja #1

astitcher opened this issue Apr 18, 2016 · 1 comment
Labels
bug a bug in the product

Comments

@astitcher
Copy link

Some Linux distributions (including Fedora) use "ninja-build" as the command to invoke ninja due to a pre-existing command called ninja.
@vector-of-bool
Copy link
Contributor

Thanks for the info. It is simple enough to detect ninja-build as an alternative to ninja.

I want to rework the automatic generator-detection code to be smarter, as it doesn't consider the case where the ninja command isn't actually the Ninja that's expected.

@vector-of-bool vector-of-bool added the bug a bug in the product label Apr 18, 2016
@vector-of-bool vector-of-bool mentioned this issue Sep 20, 2016
Closed
vector-of-bool pushed a commit that referenced this issue Oct 21, 2016
@bbosnjak
Merge pull request #1 from vector-of-bool/develop
04eb99c 
pull original
@andreeis andreeis mentioned this issue Oct 29, 2019
Merged
andreeis added a commit that referenced this issue Oct 31, 2019
@andreeis
CMakeTools versions newer or equal to #1.2 should not coexist with ol…
f7a2fb3 
…der versions due to changed publisher id
@andreeis andreeis mentioned this issue Oct 31, 2019
Merged
andreeis added a commit that referenced this issue Oct 31, 2019
@andreeis
Localize strings introduced by last bug fixes before releasing CMake …
3e34adc 
…Tools #1.2
@andreeis andreeis mentioned this issue Oct 31, 2019
Merged
bobbrow pushed a commit that referenced this issue Nov 1, 2019
@andreeis @bobbrow
Dev/andris/cmake tools/check publisher (#857)
a813458 
* CMakeTools versions newer or equal to #1.2 should not coexist with older versions due to changed publisher
bobbrow pushed a commit that referenced this issue Nov 1, 2019
@andreeis @bobbrow
Localize strings introduced by last bug fixes before releasing CMake …
b465044 
…Tools #1.2 (#862)

* Localize strings introduced by last bug fixes before releasing CMake Tools #1.2
andreeis added a commit that referenced this issue Nov 1, 2019
@andreeis
Temporarily revert found and delete duplicate kits strings from engli…
be2b17a 
…sh into google translate text for the release of CMakeTools #1.2
andreeis added a commit that referenced this issue Nov 1, 2019
@andreeis
Temporarily revert uninstall.old.cmaketools string from english into …
cf94066 
…google translate text for the release of CMakeTools #1.2
andreeis pushed a commit that referenced this issue Nov 1, 2019
@csigs @andreeis
[Auto] Localization - Translated Strings (#861)
489b4d4 
* Localization - Translated Strings

* Temporarily revert found and delete duplicate kits strings from english into google translate text for the release of CMakeTools #1.2

* Temporarily revert uninstall.old.cmaketools string from english into google translate text for the release of CMakeTools #1.2

* Copy button.no translation from cmake-tools into extension.ts

* Fixed italian translation for uninstall.old.cmaketools
andreeis added a commit that referenced this issue Nov 12, 2019
@andreeis
Changelog and version update for CMake Tools Extension Release #1.2.2
7172582
@andreeis andreeis mentioned this issue Nov 12, 2019
Merged
bobbrow added a commit that referenced this issue Nov 12, 2019
@bobbrow
Merge pull request #907 from microsoft/dev/andris/cmake_tools/release…
f524926 
…_notes_1.2.2

Changelog and version update for CMake Tools Extension Release #1.2.2
Zingam pushed a commit to Zingam/vscode-cmake-tools that referenced this issue Nov 21, 2019
@andreeis @Zingam
Dev/andris/cmake tools/check publisher (microsoft#857)
d82a651 
* CMakeTools versions newer or equal to microsoft#1.2 should not coexist with older versions due to changed publisher
Zingam pushed a commit to Zingam/vscode-cmake-tools that referenced this issue Nov 21, 2019
@andreeis @Zingam
Localize strings introduced by last bug fixes before releasing CMake …
2827372 
…Tools microsoft#1.2 (microsoft#862)

* Localize strings introduced by last bug fixes before releasing CMake Tools microsoft#1.2
Zingam pushed a commit to Zingam/vscode-cmake-tools that referenced this issue Nov 21, 2019
@csigs @Zingam
[Auto] Localization - Translated Strings (microsoft#861)
0e69f75 
* Localization - Translated Strings

* Temporarily revert found and delete duplicate kits strings from english into google translate text for the release of CMakeTools microsoft#1.2

* Temporarily revert uninstall.old.cmaketools string from english into google translate text for the release of CMakeTools microsoft#1.2

* Copy button.no translation from cmake-tools into extension.ts

* Fixed italian translation for uninstall.old.cmaketools
Zingam pushed a commit to Zingam/vscode-cmake-tools that referenced this issue Nov 21, 2019
@andreeis @Zingam
Changelog and version update for CMake Tools Extension Release micros…
60c32c3 
…oft#1.2.2
andreeis added a commit that referenced this issue Nov 26, 2019
@andreeis
Update HandleBars version. Bump up CMake Tools Release version to #1.2.3
959e020
@andreeis andreeis mentioned this issue Nov 26, 2019
Merged
andreeis added a commit that referenced this issue Nov 27, 2019
@andreeis
Update HandleBars version. Bump up CMake Tools Release version to #1.…
de7672c 
…2.3 (#947)

Update HandleBars version. Bump up CMake Tools Release version to #1.2.3
andreeis added a commit that referenced this issue Feb 6, 2020
@andreeis
Update CHANGELOG.md for CMake Tools #1.3 release
4f36cf2
andreeis added a commit that referenced this issue Feb 6, 2020
@andreeis
Update CHANGELOG.md for CMake Tools #1.3 release (#1048)
1f64f5d 
* Update CHANGELOG.md for CMake Tools #1.3 release

* Add ' for variable name
andreeis added a commit that referenced this issue Feb 6, 2020
@andreeis
Merge pull request #1049 from microsoft/develop
6dd1767 
Merge develop into master for CMake Tools #1.3.0 release.
andreeis added a commit that referenced this issue Feb 7, 2020
@andreeis
Merge pull request #1052 from microsoft/develop
dc6c6b2 
Merge latest fixes from develop into master for CMake Tools #1.3.0 release
andreeis added a commit that referenced this issue May 13, 2020
@andreeis
Version and changelog updates for CMake Tools #1.4 release.
f7b1819
bobbrow added a commit that referenced this issue May 14, 2020
@bobbrow
Merge pull request #1236 from microsoft/dev/andris/cmake_tools/Releas…
fe1f910 
…e1.4

Version and CHANGELOG updates for CMake Tools #1.4 release.
This was referenced May 20, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@riri riri mentioned this issue Apr 29, 2021
Closed
bobbrow pushed a commit that referenced this issue Jun 14, 2021
@elahehrashedi
(#1 in order) upgrade the tests [ready] (#1881)
75c91a1
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug a bug in the product
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@astitcher @vector-of-bool