Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-cl diagnostics don't appear in Problems view #517

Closed
nnemkin opened this issue Aug 18, 2018 · 3 comments
Closed

clang-cl diagnostics don't appear in Problems view #517

nnemkin opened this issue Aug 18, 2018 · 3 comments
Labels
bug a bug in the product Feature: build quick fix the fix is estimated to be quick
Milestone
1.8.0

Comments

@nnemkin
Copy link

nnemkin commented Aug 18, 2018

clang-cl output format is a bit different from MSVC. Compare:

  • [build] ..\src\lexer.c(50): error C2065: 'tre': undeclared identifier (cl).
  • [build] ..\src\lexer.c(50,20): error: use of undeclared identifier 'tre' (clang-cl).

In particular, clang-cl doesn't use error codes.
@vector-of-bool vector-of-bool added the bug a bug in the product label Sep 17, 2018
@vector-of-bool vector-of-bool added this to the Backlog milestone Sep 17, 2018
@vector-of-bool
Copy link
Contributor

Sorry for the delay.

Good to know. Should be a simple regex tweak.

@lygstate
Copy link
Contributor

Yeap, but how.

@vector-of-bool
Copy link
Contributor

Possibly another diagnostic parser class now that I've refactored the diagnostic parsing. Check the src/diagnostics/ directory

@andreeis andreeis mentioned this issue Nov 9, 2020
Closed
@bobbrow bobbrow added the quick fix the fix is estimated to be quick label Nov 9, 2020
@bobbrow bobbrow modified the milestones: Backlog, 1.6.0 Nov 9, 2020
@andreeis andreeis mentioned this issue Dec 1, 2020
Closed
@bobbrow bobbrow modified the milestones: 1.6.0, 1.7.0 Feb 16, 2021
@bobbrow bobbrow modified the milestones: 1.7.0, 1.8.0 Apr 23, 2021
ki-bo added a commit to ki-bo/vscode-cmake-tools that referenced this issue May 3, 2021
@ki-bo
Allow msvc diagnostics parser to handle both visual studio and clang-…
7d7cfbd 
…cl compiler warning/error output styles (microsoft#517)
ki-bo added a commit to ki-bo/vscode-cmake-tools that referenced this issue May 3, 2021
@ki-bo @Robert-Steffens
Allow msvc diagnostics parser to handle warning/error formats of both…
3071ac4 
… cl.exe and clang-cl compiler (microsoft#517)
@ki-bo ki-bo mentioned this issue May 3, 2021
Merged
ki-bo added a commit to ki-bo/vscode-cmake-tools that referenced this issue May 3, 2021
@ki-bo @Robert-Steffens
Allow msvc diagnostics parser to handle warning/error formats of both…
e62663e 
… cl.exe and clang-cl compiler (microsoft#517)
ki-bo added a commit to ki-bo/vscode-cmake-tools that referenced this issue May 4, 2021
@ki-bo
Allow msvc diagnostics parser to handle warning/error formats of both…
72f59fa 
… cl.exe and clang-cl compiler (microsoft#517)
ki-bo added a commit to ki-bo/vscode-cmake-tools that referenced this issue May 8, 2021
@ki-bo
Allow msvc diagnostics parser to handle warning/error formats of both…
9b62a01 
… cl.exe and clang-cl compiler (microsoft#517)
andreeis added a commit that referenced this issue Jul 8, 2021
@ki-bo @andreeis
Allow msvc diagnostics parser to handle warning/error formats of both…
4340352 
… cl.exe and clang-cl compiler (#517) (#1828)

Co-authored-by: Andreea Isac <48239328+andreeis@users.noreply.github.com>
@bobbrow bobbrow closed this as completed Aug 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug a bug in the product Feature: build quick fix the fix is estimated to be quick
Projects
None yet
Milestone
1.8.0
Development

No branches or pull requests
5 participants
@lygstate @nnemkin @bobbrow @vector-of-bool @andreeis