Silent scan for kits to avoid breaking changes in kits definition #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbrow
requested changes
May 5, 2020
…ement some versioning functionality.
…mit to this bug fix branch.
bobbrow
requested changes
May 13, 2020
…m/microsoft/vscode-cmake-tools into dev/andris/cmake_tools/github1195
bobbrow
approved these changes
May 13, 2020
bobbrow
reviewed
May 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #1195.
Silently scan for kits to ensure the users do not encounter kits breaking changes (that are solvable with scanning).
If this causes any inconvenience for the users, there is the setting cmake.scanForKitsOnOpen (defaulting to true) which can be set to false.
Many places available for hooking this. I chose at the end of workspace open and before configuring.
This happens also before the silent scan triggered by missing or empty kits json. That change will be in effect less than before this PR (for opening, never) but it can still happen when kits get deleted or corrupted between opening a workspace and any operations that triggers configuration.