Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output parser for Wind River Diab compiler #1267

Merged
merged 3 commits into from
Jul 15, 2020

Conversation

ce3a
Copy link
Contributor

@ce3a ce3a commented May 27, 2020

This changes

This adds an additional output parser ('diab').

The purpose of this change

This allows capturing diagnostic messages (errors, warnings, etc) reported by the Wind River Diab compiler.

@msftclas
Copy link

msftclas commented May 27, 2020

CLA assistant check
All CLA requirements met.

@ce3a ce3a force-pushed the dev/ce3a/diab branch from 0e7d354 to 33717ac Compare May 27, 2020 09:18
@ce3a ce3a marked this pull request as ready for review May 27, 2020 12:09
Copy link
Member

@bobbrow bobbrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I have one minor change request in the package.nls.json file.

package.nls.json Outdated
@@ -67,7 +67,7 @@
"cmake-tools.configuration.cmake.ctestPath.description": "Path to CTest executable. If null, will be inferred from cmake.cmakePath (recommended to leave null).",
"cmake-tools.configuration.cmake.ctest.parallelJobs.description": "The number of parallel test jobs. Use zero to use the value of cmake.parallelJobs.",
"cmake-tools.configuration.cmake.parseBuildDiagnostics.description": "Parse compiler output for warnings and errors.",
"cmake-tools.configuration.cmake.enabledOutputParsers.description": "Output parsers to use. Supported parsers 'cmake', 'gcc', 'gnuld' for GNULD-style inker output, 'msvc' for Microsoft Visual C++, and 'ghs' for the Green Hills compiler with --no_wrap_diagnostics --brief_diagnostics.",
"cmake-tools.configuration.cmake.enabledOutputParsers.description": "Output parsers to use. Supported parsers 'cmake', 'gcc', 'gnuld' for GNULD-style inker output, 'msvc' for Microsoft Visual C++, 'ghs' for the Green Hills compiler with --no_wrap_diagnostics --brief_diagnostics and 'diab' for the Wind River Diab compiler.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick, can you add a comma before the and?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobbrow Thanks for reviewing. I have amended the commit.

@ce3a ce3a force-pushed the dev/ce3a/diab branch from 33717ac to bd3f8f8 Compare July 7, 2020 11:51
@bobbrow bobbrow merged commit a265d47 into microsoft:develop Jul 15, 2020
@bobbrow
Copy link
Member

bobbrow commented Sep 17, 2020

This is available in 1.4.2

@bobbrow bobbrow added this to the 1.4.2 milestone Sep 17, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants