Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vendor hostOs targetOs targetArch versionMajor versionMinor attributes for kit. #1337

Merged
merged 2 commits into from
Feb 19, 2021

Conversation

lygstate
Copy link
Contributor

@lygstate lygstate commented Jun 29, 2020

Add vendor hostOs targetOs targetArch versionMajor versionMinor attributes for kit.
Fixes #462

@lygstate lygstate changed the title Add vendor hostOs targetOs targetArch versionMajor versionMinor attri… Add vendor hostOs targetOs targetArch versionMajor versionMinor attributes for kit. Jun 29, 2020
@lygstate lygstate force-pushed the kit-infos branch 9 times, most recently from c8fee6f to f322bd5 Compare June 29, 2020 08:13
@lygstate lygstate force-pushed the kit-infos branch 8 times, most recently from deae1b6 to 983bad9 Compare June 29, 2020 16:13
@bobbrow
Copy link
Member

bobbrow commented Jun 29, 2020

Thank you for your contribution. One quick question. Is it possible to query these attributes at the point where the kit is selected instead of modifying the definition of a Kit? Changing the Kit definition on disk is disruptive for people and I haven't reviewed this PR extensively enough to determine whether it is actually required.

@lygstate
Copy link
Contributor Author

I am not sure if that possible, cause it's need the version info of the compiler, and that was detected at the scan procedure

@lygstate
Copy link
Contributor Author

Where does the travis result gone.

@bobbrow
Copy link
Member

bobbrow commented Jun 29, 2020

The detection just invokes the compiler with -v and reads the stderr. I think that could be done when the kit is selected.

@lygstate
Copy link
Contributor Author

The detection just invokes the compiler with -v and reads the stderr. I think that could be done when the kit is selected.

OK, I'll try it:)

@lygstate lygstate force-pushed the kit-infos branch 2 times, most recently from d246da4 to a055833 Compare July 22, 2020 21:25
@lygstate
Copy link
Contributor Author

@bobbrow done, wish you have time to do a review. I add a function getKitExpand to be called in _setKit

@lygstate
Copy link
Contributor Author

CI not triggered again.

@lygstate lygstate force-pushed the kit-infos branch 10 times, most recently from c437c5f to bb856e4 Compare January 6, 2021 17:35
@lygstate
Copy link
Contributor Author

@bobbrow ping for merge

@andreeis
Copy link
Contributor

We apologize for taking so long to finalize a review of this change. We are wrapping up another project. Thank you for your patience while we catch up with the PRs and high priority bugs.

@bobbrow bobbrow modified the milestones: 1.6.0, 1.7.0 Feb 8, 2021
@lygstate lygstate force-pushed the kit-infos branch 8 times, most recently from 7f77c90 to 988cb17 Compare February 16, 2021 13:05
Add buildKitName buildKitHostOs buildKitTargetOs buildKitTargetArch buildKitVersionMajor buildKitVersionMinor attributes for kit.

The KitDetect result that can be configured by the user directly.

Detecting gcc triple and clang triple properly

Now detecting gcc triple and clang triple from Target: attribute.
Or from line starts with `Reading specs from` for very old compilers such as:
```
Reading specs from C:\\WindRiver-VxWorks653-2.2.0.0\\gnu\\3.3.2-vxworks653\\x86-win32\\bin\..\\lib\\gcc-lib\\powerpc-wrs-vxworksae\\3.3.2\\specs
Reading specs from ../lib/gcc-lib/powerpc-wrs-vxworks/gcc-2.96/specs
```

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
@andreeis andreeis merged commit 6bcd2e3 into microsoft:develop Feb 19, 2021
@lygstate lygstate deleted the kit-infos branch February 19, 2021 14:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question? How to use kits in "cmake.buildDirectory"
3 participants