Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set application run directory to executable path #1397

Merged
merged 3 commits into from
Aug 21, 2020
Merged

Set application run directory to executable path #1397

merged 3 commits into from
Aug 21, 2020

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Aug 5, 2020

This change addresses item #1395

This changes run and debugging behavior

The following changes are proposed:

  • Run and debug directory set to the application directory.

The purpose of this change

If the application writes files, then it will not output them to the workspace folder. It will also work correctly if it uses shared objects (plugins), which are copied to its folder. This is how it works in most IDE's.

Other Notes/Information

I applied changed suggested by @alan-wr. But it works for run without debug. It looks like cwd: '${workspaceFolder}', not expanded.

Testing project.zip

@ghost
Copy link

ghost commented Aug 5, 2020

CLA assistant check
All CLA requirements met.

@Shatur
Copy link
Contributor Author

Shatur commented Aug 5, 2020

I figured it out, now works as expected.

@Shatur Shatur marked this pull request as ready for review August 5, 2020 20:22
@bobbrow bobbrow added this to the 1.5.0 milestone Aug 10, 2020
@bobbrow
Copy link
Member

bobbrow commented Aug 10, 2020

Thanks @Shatur95! We're finishing up another project this week and are hoping to get back to CMake Tools next week and review your PR.

@Shatur
Copy link
Contributor Author

Shatur commented Aug 10, 2020

Thanks! I'm looking forward to it.

@bobbrow bobbrow merged commit 1def55f into microsoft:develop Aug 21, 2020
@Shatur Shatur deleted the use-application-dir branch August 22, 2020 07:23
@Shatur
Copy link
Contributor Author

Shatur commented Aug 22, 2020

Thank you!

alan-wr added a commit to alan-wr/vscode-cmake-tools that referenced this pull request Aug 22, 2020
Set application run directory to executable path (microsoft#1397)
@Shatur Shatur mentioned this pull request Aug 23, 2020
@Shatur
Copy link
Contributor Author

Shatur commented Aug 31, 2020

@bobbrow, could you draft a new release with this change?
I see that a fairly large 0.5 milestone is planned, but it would be nice to get the recent fixes sooner.

@bobbrow
Copy link
Member

bobbrow commented Aug 31, 2020

If you want to build your own, the process is pretty quick.

  1. Install VSCE: npm install -g vsce
  2. In the root of the repository, run: vsce package --yarn -o cmake-tools.vsix
  3. Run the "Extensions: Install From VSIX" command in VS Code and select the cmake-tools.vsix you built in step 2.

@Shatur
Copy link
Contributor Author

Shatur commented Sep 1, 2020

Thanks! Yes, I know how to build it manually, but just need to do it on every machine.
But not a problem of course.

@bobbrow
Copy link
Member

bobbrow commented Sep 1, 2020

You shouldn't need to build it on every machine, but you will need to manually install it on each machine. Is that what you meant?

@Shatur
Copy link
Contributor Author

Shatur commented Sep 1, 2020

Yes, that's why I suggested draft release with recent fixes.
But I changed my mind, will built it manually until the next release. Thanks for quick response!

@bobbrow
Copy link
Member

bobbrow commented Sep 1, 2020

Unfortunately we don't have an insiders program set up for this extension yet. If we uploaded to the Marketplace it would go to everyone and we're not ready to do that yet.

@alan-wr
Copy link
Contributor

alan-wr commented Sep 1, 2020

It is better to have daily or commit extension binary.

@bobbrow bobbrow modified the milestones: 1.6.0, 1.5.0 Oct 15, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants