Fixes conflict between -DCMAKE_GENERATOR:STRING=Ninja and -G "Visual Studio 16 2019" -A x64
#1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toolchain, prefre using "-DCMAKE_GENERATOR:STRING=", as "-DCMAKE_GENERATOR:STRING=" can be defined by different cmake-variants.yaml Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
xisui-MSFT
previously approved these changes
Apr 14, 2021
lygstate
changed the title
|
@bobbrow Hi this fixes a issue , hopt it merged in 1.7.1 |
lygstate
changed the title
-DCMAKE_GENERATOR:STRING=Ninja and -G "Visual Studio 16 2019" -A x64
|
Thank you for all of the PR's @lygstate. 1.7.1 was primarily a patch for a critical issue and we didn't have time to assess your PR's. I think we will do a 1.7.2 with another patch for CMake Presets next week so we may be able to get some of these open PR's into that. |
bobbrow
approved these changes
May 4, 2021
|
@lygstate, your contribution is included in 1.7.2 which will release in a few days. If you would like, you can try this vsix (https://github.com/microsoft/vscode-cmake-tools/actions/runs/811030625) to get this support before we release 1.7.2. |
andreeis
added a commit
that referenced
this pull request
May 6, 2021
* Fix typo in CMakePresets.json schema (#1809) MinSizRel => MinSizeRel * update version to 1.7.2 * Localize an error message * Added counts for presets (#1819) * override the locale when querying compiler versions (#1824) * Adopt new localization process (#1831) * Fix Operator Precedence when Getting Code Page (#1808) The replacing should happen after the "??" operator. Fixes #1615 Co-authored-by: Andreea Isac <48239328+andreeis@users.noreply.github.com> * If we have both "-DCMAKE_GENERATOR:STRING=" and the generator from (#1753) toolchain, prefre using "-DCMAKE_GENERATOR:STRING=", as "-DCMAKE_GENERATOR:STRING=" can be defined by different cmake-variants.yaml Signed-off-by: Yonggang Luo <luoyonggang@gmail.com> Co-authored-by: Andreea Isac <48239328+andreeis@users.noreply.github.com> * Use stricter type checks in presets expansion (#1818) * Use stricter type checks in presets expansion * Resolving comments Co-authored-by: Andreea Isac <48239328+andreeis@users.noreply.github.com> * Fix paths of target sources outside the workspace (#1816) * Fix paths of target sources outside the workspace For more details, see: #1504 * Add test for source files outside of workspace root Co-Authored-By: Elson Wei <elson.wei@gmail.com> Co-authored-by: Elson Wei <elson.wei@gmail.com> Co-authored-by: Bob Brown <bobbrow@users.noreply.github.com> * CHANGELOG updates for 1.7.2 (#1837) Co-authored-by: BlueC0re <bluec0re@users.noreply.github.com> Co-authored-by: Bob Brown <bobbrow@users.noreply.github.com> Co-authored-by: Bob Brown (DEVDIV) <bobbrow@microsoft.com> Co-authored-by: xisui-MSFT <44103947+xisui-MSFT@users.noreply.github.com> Co-authored-by: Colen Garoutte-Carson <49173979+Colengms@users.noreply.github.com> Co-authored-by: Huang, Zhaoquan <zhaoquan2008@hotmail.com> Co-authored-by: Yonggang Luo <luoyonggang@gmail.com> Co-authored-by: Simon Leiner <sleiner@users.noreply.github.com> Co-authored-by: Elson Wei <elson.wei@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have both "-DCMAKE_GENERATOR:STRING=" and the generator from
toolchain, prefre using "-DCMAKE_GENERATOR:STRING=", as
"-DCMAKE_GENERATOR:STRING=" can be defined by different cmake-variants.yaml