Remove MinGW paths only when using a MinGW kit #3138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3136 and maybe #3125 and #3127
The issue with the old code was that it always stripped MinGW paths from the
PATH
environment variable even if a MinGW compiler hadn't been detected earlier and moved to the beginning ofPATH
. This causes problems when attempting to use MinGW without specifying a kit, as MinGW will vanish entirely fromPATH
.FYI @philippewarren