Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix miDebuggerPath problem with fallback behavior #429

Merged
merged 21 commits into from
Jun 5, 2018

Conversation

KoeMai
Copy link
Contributor

@KoeMai KoeMai commented May 13, 2018

This change addresses item #375 and #242

Same as #420.

Additional it has a test debugger command mechanism and a fallback to gdb in search path.

Fallback behavior

[proc] Executing command: /usr/bin/lldb-4.0 --version
[proc] Executing command: /usr/bin/gdb-4.0 --version
[proc] Executing command: gdb --version

Removed debugger integration into kit file.

KoeMai and others added 12 commits May 7, 2018 22:12
This refactoring extracts the logic to generate
debugconfigurations from the debug command into a new module.
This new module generates debugConfigurations out of
the cmakecache and support now the generation of miDebuggerPath.
This module is reintegrated into the debug command.
Apple use always the llvm backend to compile, this makes it
necessary to call lldb instead of gdb for gcc.
…hTarget to reuse setters and getters.

The debugger had always target name and path as independent information.
This information are part of the ExecutableTarget. This refactoring use in the launch
and call step of the debugger the ExecutableTarget.

- Replace separate target name and path parameter by ExecutableTarget
- Add debugger integration tests
- Refactor set and get launchTarget
The needed debugger dependes in some cases from the used compiler.
This modification adds a section for the debugger into the kit file.

This allows to switch gdb dependent on the used gcc or clang compiler.
@KoeMai KoeMai changed the title Bugfix miDebuggerPath problem Bugfix miDebuggerPath problem with fallback behavior May 13, 2018
@vector-of-bool
Copy link
Contributor

Can #420 be closed?

@KoeMai
Copy link
Contributor Author

KoeMai commented May 21, 2018

The testing fails on windows, it needs the extension cpptools for the cppvdbg debug launch.
Do we want this kind of extension test?

@vector-of-bool
Copy link
Contributor

Hmm... what about separating the generation of the DebugConfiguration and testing the generation of that config without launching a debugger?

@vector-of-bool vector-of-bool merged commit b10aa98 into develop Jun 5, 2018
@vector-of-bool vector-of-bool added this to the 1.0.0 milestone Jun 5, 2018
@KoeMai KoeMai deleted the bugfix/debugger_kit branch June 5, 2018 04:55
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants