Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform Build as Task (among other minor updates) #647

Merged
merged 7 commits into from
Apr 3, 2019
Merged

Perform Build as Task (among other minor updates) #647

merged 7 commits into from
Apr 3, 2019

Conversation

emanspeaks
Copy link
Contributor

@emanspeaks emanspeaks commented Feb 5, 2019

Proposed behavior changes

The following changes are proposed:

  • Perform build in an integrated terminal
  • Provide more robust checking of Windows paths stored in environment variables
  • Allow skipping the definition of kit environment when doing Visual Studio builds
  • Load CMake Cache as text file (previewHtml is deprecated anyways)
  • Remove hard-coded flags for Visual Studio builds

The purpose of this change

While attempting to build a project with Visual Studio 2017, I encountered issues caused by the presence of the hard-coded flags. Since the user can add buildArgs in the settings, these flags should be manually added by the user, or set as the default value of buildArgs. Once I removed the flags, the build at least started, but encountered errors with using Intel compilers in Visual Studio. Suspecting environment problems, I added the capability to ignore the VS environment. I was still unable to verify the cause of the issue, but noticed that if I copy and pasted the command generated by CMake Tools into an integrated terminal, the build would run successfully. I subsequently changed the build command to provide a command string for a task. I also wanted to add custom configureSettings that are loaded from environment variables, so I needed to enhance this capability to eliminate a number of errors.

src/driver.ts Outdated Show resolved Hide resolved
@emanspeaks emanspeaks changed the title Perform Build in Terminal (among other minor updates) Perform Build as Task (among other minor updates) Feb 5, 2019
@emanspeaks
Copy link
Contributor Author

This should be ready to merge after someone reviews it...just waiting on a review.

Copy link
Contributor

@no-realm no-realm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to merge this for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants