debugTarget keybinding conflicts with vscode default #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colengms
approved these changes
Oct 16, 2019
michelleangela
approved these changes
Oct 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses item #700
This changes activation conditions
The following changes are proposed:
CTL+F5 will not activate the CMake Tools extension and attempt to debug a target. This keybinding will only be active if the extension is already activated.
The purpose of this change
To not interfere with VS Code defaults outside of the context of a CMake project.
Other Notes/Information
I took this approach instead of changing the keybinding so as not to confuse long-time users who may have gotten accustomed to using CTL+F5 to launch debugging via the CMake Tools extension.