Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support usage of env vars for Kit.toolchainFile #991

Merged
merged 11 commits into from
Oct 7, 2020
Merged

Support usage of env vars for Kit.toolchainFile #991

merged 11 commits into from
Oct 7, 2020

Conversation

bobbrow
Copy link
Member

@bobbrow bobbrow commented Dec 30, 2019

This PR replaces #626 by @blakehurd

@bobbrow bobbrow mentioned this pull request Dec 30, 2019
Closed
@bobbrow bobbrow added this to the On Deck milestone Jan 27, 2020
@bobbrow bobbrow mentioned this pull request Feb 10, 2020
Closed
@bobbrow bobbrow requested review from andreeis and a team February 11, 2020 21:14
@bobbrow bobbrow modified the milestones: On Deck, 1.4.0 Feb 11, 2020
@andreeis andreeis modified the milestones: 1.4.0, 1.5.0 Apr 1, 2020
@andreeis
Copy link
Contributor

andreeis commented Oct 7, 2020

I verified all again, works great.

@andreeis andreeis merged commit 4c3b678 into develop Oct 7, 2020
@bobbrow bobbrow deleted the bobbrow/kitsVars branch October 7, 2020 15:36
@bobbrow bobbrow modified the milestones: 1.6.0, 1.5.0 Oct 15, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreeis andreeis andreeis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bobbrow @andreeis