Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chrome-maximize and chrome-restore need to be updated for Windows 11 #90

Closed
1ctinus opened this issue Oct 29, 2021 · 4 comments
Closed
Assignees

Comments

@1ctinus
Copy link

1ctinus commented Oct 29, 2021

Is your icon request related to a problem? Please describe.
The problem is that the window decorations are in the style of Windows 10, which is inconsistent with Windows 11.

Describe the solution you'd like
Round chrome-maximize and chrome-restore.

Describe alternatives you've considered
I've considered trying to make a PR, but I have no SVG of the new windows 11 controls.

@miguelsolorio
Copy link
Contributor

This will be tricky as those icons are used across other platforms that aren’t windows (Linux and Web). Will likely need to make windows specific ones.

@1ctinus
Copy link
Author

1ctinus commented Oct 30, 2021

Most windows are rounded in most operating systems nowadays (GNOME, macOS, Windows 11), so I would say the change is appropriate.

@miguelsolorio
Copy link
Contributor

Our iconography style uses bevel edges instead of rounded corners. It’s a stylistic choice we use regardless of the operating system.

@miguelsolorio
Copy link
Contributor

Closing in favor of microsoft/vscode#136132 (comment)

To solve this issue we will adopt window-controls-overlay and this should solve this issue as well.

As there will be no need for our icons to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants