Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio code seems to have Windows 10 style window controls/decorations instead of Windows 11 #136132

Closed
1ctinus opened this issue Oct 29, 2021 · 4 comments · Fixed by #147947
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders titlebar VS Code main title bar issues verified Verification succeeded windows 11 VS Code on Windows 11 issues
Milestone

Comments

@1ctinus
Copy link

1ctinus commented Oct 29, 2021

I know that the window controls are not done natively because the program is made in Javascript, but the window decorations/controls are in the style of Windows 10, which only effect the maximize/minimize button.
image
VSCode controls
image
Native Windows 11 controls

@1ctinus
Copy link
Author

1ctinus commented Oct 29, 2021

Looking into the issue, it seems like the asset that decides the look for a window icon is actually a font, not an image

@1ctinus
Copy link
Author

1ctinus commented Oct 29, 2021

This seems to be an issue with the codicons needing to be updated on more research,

@miguelsolorio
Copy link
Contributor

@sbatten given that Win 11 has a specific icon style for their windows controls, can we specify custom icons for windows?

@sbatten
Copy link
Member

sbatten commented Nov 1, 2021

To solve this issue we will adopt window-controls-overlay and this should solve this issue as well.

@sbatten sbatten added titlebar VS Code main title bar issues bug Issue identified by VS Code Team member as probable bug windows 11 VS Code on Windows 11 issues labels Nov 1, 2021
@sbatten sbatten added this to the Backlog milestone Nov 1, 2021
@bpasero bpasero modified the milestones: Backlog, May 2022 May 3, 2022
@joyceerhl joyceerhl added the verified Verification succeeded label Jun 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders titlebar VS Code main title bar issues verified Verification succeeded windows 11 VS Code on Windows 11 issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@bpasero @sbatten @joyceerhl @miguelsolorio @1ctinus and others