Add validation for untrusted GitHub API responses #1987
+605
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub API responses are untrusted external data but were being used directly without validation, creating type safety and security risks.
Changes
githubAPIValidators.ts) for 11 API response types: SessionInfo, PullRequestFile, JobInfo, IOctoKitUser, CustomAgentListItem, and response wrappersgithubAPI.tsandgithubService.ts(9 functions total)Example
Before:
After:
The validator library (similar to Zod) ensures external API data matches expected TypeScript types before use.
Original prompt
Created from VS Code.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.