-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Validate some untrusted GitHub API responses using validator system #1989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: joshspicer/api
Are you sure you want to change the base?
Validate some untrusted GitHub API responses using validator system #1989
Conversation
…all sites Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com>
Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com>
Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com>
|
@copilot For vJobInfo you're validating too strictly! 2025-11-13 18:07:16.529 [error] [GitHubService] Failed to validate job info response: Required field 'pull_request' is missing |
Fixed in f403ecb. Made |
f403ecb to
c74020c
Compare
GitHub API Response Validation - Complete ✅
Supports
makeGitHubAPIRequestfunction returningunknown(untrusted data) instead of typed responses. Callers validate responses using the validator system before use.Room for improvement here, either adding more methods to be validated or setting certain fields to required (would need confirmation from github on which fields are actually required)