Make worktree creation silent in handlePushConfirmationData workflow

[Copilot]

Worktree creation was displaying progress messages during the handlePushConfirmationData workflow, creating unnecessary noise for users. The worktree was also being created too late in the process.

Changes

• Added CopilotCLIWorktreeManager.createWorktreeSilently(): Creates worktrees without progress/warning messages
• Updated handlePushConfirmationData: Creates worktree before executing commands, respecting isolation preference
  • Checks isolation setting using temporary session ID
  • Passes workingDirectory and isolationEnabled to session creation
  • Stores worktree path for the created session

// Before: empty options, worktree created later with progress messages
const session = await this.sessionService.createSession(requestPrompt, {}, token);

// After: worktree created silently first, options populated
const isolationEnabled = this.worktreeManager.getIsolationPreference(tempSessionId);
const workingDirectory = isolationEnabled 
    ? await this.worktreeManager.createWorktreeSilently() ?? await this.getDefaultWorkingDirectory()
    : await this.getDefaultWorkingDirectory();

const session = await this.sessionService.createSession(requestPrompt, { workingDirectory, isolationEnabled }, token);

• Added test coverage: Verifies silent creation and proper worktree path storage

Original prompt

for handlePushConfirmationData workflow, the creation of worktree should be silent.

[Chronological Review: The conversation began with the user expressing concerns about a code path not respecting isolation/worktree settings. The user then questioned whether a feature should be gated by a setting. Following that, the user pointed out that the worktree was being created too early in the process and asked about the delegation of requests. The user continued to refine the workflow by specifying that the worktree creation should be silent during the handlePushConfirmationData workflow. Finally, the user issued a command to delegate to a cloud agent.]

[Intent Mapping:

1. "this code path doesn't seem to respect isolation / worktree setting" - User wants to address a potential issue in the code.
2. "shouldn't this feature (reading the preference from global memento) be gated by the setting as well?" - User seeks to ensure proper feature gating.
3. "this is actually wrong, we are creating the worktree too early." - User identifies a timing issue in the workflow.
4. "before we run await this.commandExecutionService.executeCommand(...), we should create a session worktree" - User specifies the correct order of operations.
5. "for handlePushConfirmationData workflow, the creation of worktree should be silent." - User wants to suppress output during a specific workflow.
6. "Delegate: 'Delegate to cloud agent'" - User requests delegation to a cloud agent.]

[Technical Inventory:

• Command Execution Service: Used to execute commands within the VSCode environment.
• Worktree: A temporary workspace created for handling specific tasks.
• Global Memento: A storage mechanism for user preferences/settings in VSCode.]

[Code Archaeology:

• File: /Users/penlv/Code/Work/vscode-copilot-chat/src/extension/chatSessions/vscode-node/copilotCLIChatSessionsContribution.ts
• Recent focus on the handleRequest and handlePushConfirmationData workflows, particularly around the timing and visibility of worktree creation.]

[Progress Assessment:

• Completed: User has identified issues with the current implementation and provided specific guidance on how to address them.
• Pending: Implementation of the user's suggestions regarding worktree creation timing and visibility.]

[Context Validation: All critical information regarding the user's requests and the current state of the code has been captured for continuation.]

[Recent Commands Analysis:

• Last Agent Commands: User issued a command to delegate to a cloud agent.
• Tool Results Summary: No specific tool results were returned as the command was a directive rather than a tool execution.
• Pre-Summary State: The agent was actively discussing the workflow for creating a worktree and its timing in relation to command execution when the token budget was exceeded.
• Operation Context: The user is refining the workflow for handling chat sessions in the VSCode Copilot extension, focusing on the correct timing and visibility of operations.]

1. Conversation Overview: - Primary Objectives: - "this code path doesn't seem to respect isolation / worktree setting" - "shouldn't this feature (reading the preference from global memento) be gated by the setting as well?" - "this is actually wrong, we are creating the worktree too early." - "before we run `await this.commandExecutionService.executeCommand(...)`, we should create a session worktree" - "for handlePushConfirmationData workflow, the creation of worktree should be silent." - "Delegate: 'Delegate to cloud agent'" - Session Context: The user is refining the implementation of chat session handling in the VSCode Copilot extension, focusing on worktree management and command execution order. - User Intent Evolution: The user has progressively clarified their requirements regarding the timing and visibility of worktree creation, culminating in a request to delegate to a cloud agent.

2. Technical Foundation:

• Command Execution Service: Used to execute commands within the VSCode environment.
• Worktree: A temporary workspace created for handling specific tasks.
• Global Memento: A storage mechanism for user preferences/settings in VSCode.

3. Codebase Status:

• File Name: /Users/penlv/Code/Work/vscode-copilot-chat/src/extension/chatSessions/vscode-node/copilotCLIChatSessionsContribution.ts
• Purpose: Handles chat session contributions in the VSCode Copilot extension.
• Current State: User has identified issues with the timing of worktree creation and has provided specific guidance on how to address them.
• Key Code Segments: Focus on handleRequest and handlePushConfirmationData workflows.
• Dependencies: Relies on the command execution service for executing commands.

4. Problem Resolution:

• Issues Encountered: Timing of worktree creation and visibility during specific workflows.
• Solutions Implemented: User has provided clear directives on how to adjust the workflow.
• Debugging Cont...

Created from VS Code.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.