Skip to content

Commit

Permalink
Fix 'Build and Debug Active File' race condition with EngineLogs (#6304)
Browse files Browse the repository at this point in the history
* Fix 'Build and Debug Active File' race condition with EngineLogs

If users use 'Build and Debug Active File' with "engineLogging", the resolveDebugConfigurations will quickly switch to the output window and `${fileBasenameNoExtension}` will resolve to something similar to `./extension-output-#5`.

This may be a bug with VS Code determining the output window to be a file, but this will unblock users who need to enable engine logging for this scenario.
  • Loading branch information
WardenGnaw authored Oct 14, 2020
1 parent 20759af commit 9dfb2c6
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Extension/src/Debugger/configurationProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,8 @@ class CppConfigurationProvider implements vscode.DebugConfigurationProvider {
const outputChannel: logger.Logger = logger.getOutputChannelLogger();
outputChannel.appendLine(localize("debugger.launchConfig", "Launch configuration:"));
outputChannel.appendLine(JSON.stringify(config, undefined, 2));
logger.showOutputChannel();
// TODO: Enable when https://github.com/microsoft/vscode/issues/108619 is resolved.
// logger.showOutputChannel();
}

return config;
Expand Down

0 comments on commit 9dfb2c6

Please sign in to comment.