Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Outline with C++20 namespace ::inline syntax #7216

Closed
sean-mcmanus opened this issue Mar 23, 2021 · 3 comments
Closed

Incorrect Outline with C++20 namespace ::inline syntax #7216

sean-mcmanus opened this issue Mar 23, 2021 · 3 comments
Labels
bug Feature: Document Symbol Outline view and breadcrumbs fixed Check the Milestone for the release in which the fix is or will be available. Language Service Visual Studio Inherited from Visual Studio
Milestone

Comments

@sean-mcmanus
Copy link
Collaborator

The examples I gave all look like they have been fixed, however I found a new example that is not outlined correctly:

namespace foo::bar {
    namespace baz::inline boop {
        class beep {
        public:
            beep();
        };

        int foobarbaz();
    }
}

Screenshot_2021-03-23_10-11-39

Of course, this syntax is new to c++20, so it is understandable that it's not fully supported yet. Using the pre-c++20 syntax yields the right outline:

namespace foo::bar {
    namespace baz {
        inline namespace boop {
            class beep {
            public:
                beep();
            };

            int foobarbaz();
        }
    }
}

Originally posted by @BigBahss in #6830 (comment)

@sean-mcmanus sean-mcmanus self-assigned this Mar 23, 2021
@sean-mcmanus sean-mcmanus added bug Feature: Document Symbol Outline view and breadcrumbs Language Service Visual Studio Inherited from Visual Studio labels Mar 23, 2021
@sean-mcmanus sean-mcmanus added this to the Tracking milestone Mar 23, 2021
@sean-mcmanus
Copy link
Collaborator Author

@BigBahss Thanks for reporting this. I've filed a bug against our shared VS parser at https://developercommunity.visualstudio.com/t/C20-tag-parser-doesnt-work-with-names/1379199 . They usually prioritize C++20 features.

@sean-mcmanus sean-mcmanus removed their assignment Mar 23, 2021
@BigBahss
Copy link

Thanks Sean 👍

@sean-mcmanus sean-mcmanus modified the milestones: Tracking, 1.12 Aug 11, 2022
@sean-mcmanus sean-mcmanus modified the milestones: 1.12, 1.12.2 Aug 18, 2022
@sean-mcmanus sean-mcmanus modified the milestones: 1.12.2, 1.13 Aug 18, 2022
@sean-mcmanus sean-mcmanus modified the milestones: 1.13, 1.13.0 Aug 18, 2022
@sean-mcmanus sean-mcmanus modified the milestones: 1.13.0, 1.13.1 Sep 12, 2022
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Sep 13, 2022
@sean-mcmanus
Copy link
Collaborator Author

@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Feature: Document Symbol Outline view and breadcrumbs fixed Check the Milestone for the release in which the fix is or will be available. Language Service Visual Studio Inherited from Visual Studio
Projects
None yet
Development

No branches or pull requests

2 participants