Fix random failures when adding or removing workspace folders #10665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colengms
previously approved these changes
Mar 13, 2023
sean-mcmanus
deleted the
seanmcm/fixClientUseBeforeInitializedAddRemoveFolder
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i.e. when the client is not initialized yet.
The updateClientConfigurations case is the easiest to repro (it's hit from the 'select default compiler' initialization code in the client constructor):
The 2nd one is harder to repro, related to didOpen (not sure the exact repro requirements):
"Attempting to use languageClient before initialized"