Fix issue with cached browse config not being removed #10735
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cache the last used browse config, to avoid resetting the contents of the database on the next session while waiting for the same config provider to register again.
For security purposes, we want to clear that cached browse config if the same provider does not register in a subsequent session. Clearing the browse configuration at the end of the session is not reliable, as the call to
update
on theMomento
is async, and may not complete.With this change, we now persist the providers that have registered in a workspace folder, and, on a subsequent session, if we see that the provider of the cached browse configuration did not register in the previous session, the cached browse config removed.
Moved the persistent variables involved into the client object.