Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with cached browse config not being removed #10735

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

Colengms
Copy link
Collaborator

We cache the last used browse config, to avoid resetting the contents of the database on the next session while waiting for the same config provider to register again.

For security purposes, we want to clear that cached browse config if the same provider does not register in a subsequent session. Clearing the browse configuration at the end of the session is not reliable, as the call to update on the Momento is async, and may not complete.

With this change, we now persist the providers that have registered in a workspace folder, and, on a subsequent session, if we see that the provider of the cached browse configuration did not register in the previous session, the cached browse config removed.

Moved the persistent variables involved into the client object.

@Colengms Colengms merged commit 2ad0a95 into main Mar 23, 2023
@Colengms Colengms deleted the coleng/remove_browse_config_if_not_registered branch March 23, 2023 22:44
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants