Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from TSLint to ESLint #4974

Merged
merged 3 commits into from
Feb 18, 2020
Merged

Migrate from TSLint to ESLint #4974

merged 3 commits into from
Feb 18, 2020

Conversation

Colengms
Copy link
Contributor

Switched to using ESLint in a mode that falls back to TSLint for some rules that do not yet have equivalents in ESLint. (i.e. "encoding")

Used https://github.com/typescript-eslint/tslint-to-eslint-config to migrate existing TSLint settings to ESLint.

Addressed additional (minor) lint issues detected by ESLint by default.

The following additional/external rules plugins for TSLint are not available in ESLint:

  • ext-variable-name
  • no-unused-expression-chai
  • promise-must-complete

A roadmap for migrating the rules from tslint-microsoft-contrib is here:

Regenerated yarn.lock

@sean-mcmanus
Copy link
Contributor

Linter tests fails with Error: Failed to load plugin 'eslint-plugin-tslint' declared in '--config': Cannot find module 'eslint-plugin-tslint'
.

@Colengms Colengms merged commit 548d6a8 into master Feb 18, 2020
@Colengms Colengms deleted the coleng/eslint branch February 18, 2020 22:33
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants