Fix typo in package.json #7508
Merged
Fix typo in package.json #7508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbrow
approved these changes
May 11, 2021
|
Oops. I didn't notice this was going into the |
|
No, not possible. This PR can only target the |
|
That's fine -- I think Colen will be submitting a PR for his branch soon. Usually spelling fixes would be mentioned in a code review at the time the PR is submitted. |
|
I didn't expect anyone outside our team to find a working branch and make suggestions on an in-flight feature prior to PR, so I thought that the target branch was a mistake. I didn't pay as much attention on what was actually being changed - just that the spelling looked correct. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.