Code analysis fix formatting. #9661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not 100% ready yet, still fixing bugs. UPDATE: Bugs have been fixed. |
|
I'm investigating if there's a way to combine multiple "onChange" documentFormat requests into a single edit so they can be undone with a single undo instead of 1 per file. UPDATE: It was easy to fix. |
|
I need to set tabSize and insertSpaces somehow when I invoke the format command... UPDATE: I added a fix. |
Colengms
approved these changes
Aug 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9322 .
Code action fixes are applied and then formatting is applied. The first undo undoes any formatting if any was done, otherwise it undoes the fix. If formatting was done, a 2nd undo will undo the fix. The operations apply across all files that have fixes generated for them.