Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parsing @apply rules. #10

Merged
merged 1 commit into from
Dec 3, 2016
Merged

Conversation

rictic
Copy link
Contributor

@rictic rictic commented Nov 15, 2016

Follows the proposed (WIP) spec as it exists today at https://tabatkins.github.io/specs/css-apply-rule/#using

Fixes #8

@rictic
Copy link
Contributor Author

rictic commented Nov 15, 2016

I've signed the Microsoft CLA, and contributed to other Microsoft repos, e.g. microsoft/TypeScript-DOM-lib-generator#151

@rictic
Copy link
Contributor Author

rictic commented Nov 23, 2016

Please let me know anything I can do to help this land!

I tried to make the change minimal, and follow the conventions of the repo.

@aeschli
Copy link
Contributor

aeschli commented Nov 23, 2016

@rictic Changes look good. Any reason why endOfAtApply and semicolonPosition are remembered?

@rictic
Copy link
Contributor Author

rictic commented Nov 23, 2016

Just trying to follow the conventions. AbstractDeclaration tracks colonPosition and semicolonPosition and those were the closest analogs for @apply. Might have been cargo culting though, I didn't track down how those were used.

@rictic
Copy link
Contributor Author

rictic commented Dec 1, 2016

If you like I could drop endOfAtApply and semicolonPosition, or hook them into other parts of the code. Just let me know!

@abdonrd
Copy link

abdonrd commented Dec 2, 2016

Yay! Thanks @rictic!

@aeschli aeschli merged commit 150e266 into microsoft:master Dec 3, 2016
@aeschli
Copy link
Contributor

aeschli commented Dec 3, 2016

Thanks @rictic . I polished the code a bit and simplified it. Removed the endOfAtApply and semicolonPosition, and also took away the test for --. This can better be done by a linter extension.

Thanks a lot for the contribution and sorry for the wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants