-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: support new resolving import at-rules #255
Conversation
@aeschli Webpack and Sass are both mentioned that imports will always be resolved relative to the current file first, see: Webpack: https://github.com/webpack-contrib/sass-loader#resolving-import-at-rules This PR support node module resolution without PS: using |
Thanks @fyangstudio. Also, it would be nice to have tests as well. |
…s-languageservice into feat-update-import
'~' is deprecated in Less too, see https://github.com/webpack-contrib/less-loader#imports I have changed it only enable new rule for Sass and Less. @aeschli Please check. By the way I think css-loader will support the new resolving import at-rules soon. |
@aeschli if this PR have any questions, please let me know. |
I polished the check whether to resolve module references (6e64249) All looks good now, thanks @fyangstudio ! |
https://github.com/webpack-contrib/sass-loader#resolving-import-at-rules
Support VS Code DefinitionProvider find right package like: