Added application details views #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philliphoff
reviewed
Jul 15, 2021
philliphoff
reviewed
Jul 15, 2021
philliphoff
reviewed
Jul 15, 2021
philliphoff
reviewed
Jul 15, 2021
philliphoff
reviewed
Jul 20, 2021
| @@ -29,13 +30,14 @@ export default class DaprComponentsNode implements TreeNode { | |||
| } | |||
|
|
|||
| async getChildren(): Promise<TreeNode[]> { | |||
| //TO DO: FIX WARNING NODE | |||
There was a problem hiding this comment.
My bad, it was a comment to myself but I forgot to remove it before committing.
philliphoff
reviewed
Jul 20, 2021
| } | ||
|
|
||
| setAppDetails(application: DaprApplication | undefined) : void { | ||
| this.detailLabels = ["App ID", "App Port", "Dapr HTTP Port", "Dapr GRPC Port", "Dapr Process ID"]; |
There was a problem hiding this comment.
These (and below) labels should be localizable.
philliphoff
reviewed
Jul 20, 2021
| } | ||
|
|
||
| setComponentDetails(component: DaprComponentMetadata | undefined) : void { | ||
| this.detailLabels = ["Name", "Type", "Version"] |
There was a problem hiding this comment.
This is ok, but can lead to fragility in that the order can be easily mixed up. Perhaps something like:
this.details = [
{ label: 'Name', value: component.name },
{ label: 'Type', value: component.type },
...
];
philliphoff
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added applications details view to expose metadata as outlined in issue #161. When an application name is clicked on, the app details pane populates the data
UI:
