Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DebugSession client path conversion should work in web extensions #298

Open
idavis opened this issue Aug 16, 2023 · 0 comments
Open

DebugSession client path conversion should work in web extensions #298

idavis opened this issue Aug 16, 2023 · 0 comments

Comments

@idavis
Copy link

idavis commented Aug 16, 2023

Writing cross-platform and web cabable extensions, one is unable to call DebugSession::setDebuggerPathFormat and rely on the conversion methods for client and debugger path conversion.

Expected behavior

DebugSession::convertClientPathToDebugger and DebugSession::convertDebuggerPathToClient should work in desktop and web extensions.

Current behavior

Calling DebugSession::convertClientPathToDebugger or DebugSession::convertDebuggerPathToClient throws an exception process is not defined when DebugSession::path2uri and DebugSession::uri2path are called due to a dependency on process.platform from node.

idavis added a commit to microsoft/qsharp that referenced this issue Aug 16, 2023
This is a workaround for windows which doesn't play well with URIs. The
DAP
`setDebuggerPathFormat`/`convertClientPathToDebugger`/`convertDebuggerPathToClient`
can't be used as there is a [bug requiring
nodejs](microsoft/vscode-debugadapter-node#298)
which prevents usage in web extensions. Once the bug is fixed we can
update the debugger to use URIs without this PR's retry conversion.

This PR also fixes an issue where if the user closed the file being
debugged or it was open as 'temporarily open' then we couldn't step back
into the code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant