Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Inspect Image Manifest 404 #225

Merged
merged 1 commit into from
Mar 25, 2024
Merged

fix: Inspect Image Manifest 404 #225

merged 1 commit into from
Mar 25, 2024

Conversation

MrXhh
Copy link
Contributor

@MrXhh MrXhh commented Mar 18, 2024

  1. selected image tag: Inspect Image Manifest
  2. Request to http://localhost:5000/v2/xxx/manifests/xxx failed with status 404: Not Found

@MrXhh MrXhh requested a review from a team as a code owner March 18, 2024 09:45
@bwateratmsft
Copy link
Contributor

I was not able to reproduce the original 404 issue on any registries I tried. What registry are you using where you are seeing it? (I typically use the registry:2 image when testing a localhost registry)

@MrXhh
Copy link
Contributor Author

MrXhh commented Mar 19, 2024

I was not able to reproduce the original 404 issue on any registries I tried. What registry are you using where you are seeing it? (I typically use the registry:2 image when testing a localhost registry)我无法在我尝试的任何注册表上重现原始的404问题。你在哪里看到的是什么注册表?(我通常在测试本地主机注册表时使用 registry:2 镜像)

  1. start registry: docker run -d -p 5000:5000 --name registry registry:2
  2. build image: docker buildx build --platform linux/386,linux/amd64 ...
  3. selected image tag: Inspect Image Manifest
  4. Request to http://localhost:5000/v2/xxx/manifests/xxx failed with status 404: Not Found

@bwateratmsft
Copy link
Contributor

I pushed the image inbetween step 2 and 3 but still wasn't able to reproduce the 404. I'm concerned about changing the accept header here because it affects all requests to V2 registries, not just the image manifest requests.

@MrXhh
Copy link
Contributor Author

MrXhh commented Mar 22, 2024

@bwateratmsft
Copy link
Contributor

Thanks, I am able to reproduce now. I will try your fix.

Copy link
Contributor

@bwateratmsft bwateratmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the same accept header change to here:

'accept': 'application/vnd.docker.distribution.manifest.v2+json'

@MrXhh
Copy link
Contributor Author

MrXhh commented Mar 23, 2024

@microsoft-github-policy-service agree

@bwateratmsft
Copy link
Contributor

Looks great, thanks for the contribution @MrXhh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants