-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Inspect Image Manifest 404 #225
Conversation
MrXhh
commented
Mar 18, 2024
- selected image tag: Inspect Image Manifest
- Request to http://localhost:5000/v2/xxx/manifests/xxx failed with status 404: Not Found
I was not able to reproduce the original 404 issue on any registries I tried. What registry are you using where you are seeing it? (I typically use the |
|
I pushed the image inbetween step 2 and 3 but still wasn't able to reproduce the 404. I'm concerned about changing the accept header here because it affects all requests to V2 registries, not just the image manifest requests. |
Thanks, I am able to reproduce now. I will try your fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the same accept header change to here:
Line 165 in 41afbf0
'accept': 'application/vnd.docker.distribution.manifest.v2+json' |
packages/vscode-docker-registries/src/clients/RegistryV2/registryV2Request.ts
Outdated
Show resolved
Hide resolved
@microsoft-github-policy-service agree |
Looks great, thanks for the contribution @MrXhh! |