Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite compose commands for ACI contexts #2169

Merged
merged 3 commits into from
Jul 16, 2020
Merged

Rewrite compose commands for ACI contexts #2169

merged 3 commits into from
Jul 16, 2020

Conversation

bwateratmsft
Copy link
Collaborator

@bwateratmsft bwateratmsft commented Jul 16, 2020

1.4.0 temporary fix for #2168

@bwateratmsft bwateratmsft requested a review from a team as a code owner July 16, 2020 14:42
@bwateratmsft bwateratmsft requested a review from karolz-ms July 16, 2020 14:53
Copy link
Contributor

@karolz-ms karolz-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😑 This is fine for the upcoming release, but we should think about the implications on command customization. I think sooner or later, we will have to have something that allows users to customize commands depending on the Docker context type or associated VS Code context value.

Maybe a "CONSIDER" comment would be useful

@bwateratmsft
Copy link
Collaborator Author

bwateratmsft commented Jul 16, 2020

😑 This is fine for the upcoming release, but we should think about the implications on command customization. I think sooner or later, we will have to have something that allows users to customize commands depending on the Docker context type or associated VS Code context value.

Maybe a "CONSIDER" comment would be useful

I like what we talked about offline--add a contextType sub-property for command customizations, and have new default values that are arrays (where needed) instead of single values. I'll look at how much implementation work that would be.

We'll chat in standup. If we want this for 1.4.0 I'd say we take this current (easy/low risk) fix, and work on the "real" fix for 1.5.0.

@bwateratmsft bwateratmsft merged commit 5317a18 into master Jul 16, 2020
@bwateratmsft bwateratmsft deleted the bmw/compose branch July 16, 2020 17:42
@bwateratmsft bwateratmsft added this to the 1.4.0 milestone Jul 16, 2020
Dmarch28 pushed a commit to Dmarch28/vscode-docker that referenced this pull request Mar 4, 2021
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants