Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove coreclr debug #2331

Merged
merged 11 commits into from
Sep 18, 2020
Merged

Remove coreclr debug #2331

merged 11 commits into from
Sep 18, 2020

Conversation

bwateratmsft
Copy link
Collaborator

@bwateratmsft bwateratmsft commented Sep 17, 2020 •
edited
Loading

Fixes #2197

Tested so far:

  • .NET Core debugging (single) (Mac & Windows)
  • .NET attach + compose up (Mac & Windows)
  • .NET attach + compose debug up (Mac & Windows)
  • VsDbg not present
  • SSL cert not present
  • Python debug (sanity test of browser launch)
  • Node debug (sanity test of browser launch)
  • Windows debug

@bwateratmsft bwateratmsft requested a review from a team as a code owner September 17, 2020 19:16
karolz-ms
karolz-ms approved these changes Sep 17, 2020
View reviewed changes
src/commands/dockerInstaller.ts Outdated Show resolved Hide resolved
src/commands/installDocker.ts Outdated Show resolved Hide resolved
@bwateratmsft bwateratmsft merged commit 33f2b93 into master Sep 18, 2020
@bwateratmsft bwateratmsft deleted the bmw/coreclr branch September 18, 2020 20:11
@bwateratmsft bwateratmsft mentioned this pull request Sep 22, 2020
Closed
@bwateratmsft bwateratmsft linked an issue Sep 22, 2020 that may be closed by this pull request
Django project debug in docker container doesn't start #2313
Closed
@bwateratmsft bwateratmsft mentioned this pull request Sep 23, 2020
Closed
@bwateratmsft bwateratmsft mentioned this pull request Oct 28, 2020
Merged
@bwateratmsft bwateratmsft mentioned this pull request Nov 5, 2020
Closed
Dmarch28 pushed a commit to Dmarch28/vscode-docker that referenced this pull request Mar 4, 2021
@bwateratmsft @Dmarch28
Remove coreclr debug (microsoft#2331)
0fe6226 
* Remove coreclr debug code

* OS package usage consistency
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karolz-ms karolz-ms karolz-ms approved these changes

Assignees
No one assigned
Labels
engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Django project debug in docker container doesn't start Remove CoreCLR debug
2 participants
@bwateratmsft @karolz-ms