feat: add fastapi docker

[Kludex]

Closes #2615

[Kludex]

I'm facing issues to debug it. 😢
Can someone help me? I don't have much experience on this setup 😞

If helps:

➜  vscode-docker git:(feat/fastapi-docker) ✗ node --version
v15.10.0
➜  vscode-docker git:(feat/fastapi-docker) ✗ npm --version 
7.5.3

[bwateratmsft]

I'm facing issues to debug it. 😢
Can someone help me? I don't have much experience on this setup 😞

If helps:

➜  vscode-docker git:(feat/fastapi-docker) ✗ node --version
v15.10.0
➜  vscode-docker git:(feat/fastapi-docker) ✗ npm --version 
7.5.3

Could be the same issue as what's causing #2498? There's a bug in VSCode somewhere that causes terminals to not work. Seems like a very active issue (100+ comments): microsoft/vscode#105446

[Kludex]

I'm going to check that in some hours. Thank you!

Do I need to add specific tests? For Django and Flask it looks like they are handled by "python containers" instead of something specific. Am I wrong?

[bwateratmsft]

Unfortunately we have pretty little in the way of automated tests, and most of what we do have makes more noise than signal 😞

So nothing in particular to add for now.

[Kludex]

Yeah... I've tried some stuff, also downloaded insiders. But it didn't work.

I'm not going to have time to check it again before the weekend, jfyk @bwateratmsft

[bwateratmsft]

No problem. I'll try to find some time to test these changes out.

[bwateratmsft]

Ok, I was able to test it out, bumped into a couple of issues.

1. I need to revert Remove Python code to override entrypoint #2732 and fix it a different way. My bad!
2. The grouping logic for the "Now listening" regex wasn't right; non-capturing groups did not work as I'd expected. Also I had a typo (missing parenthesis, fixed it above). This is the correct thing to have:

    case 'fastapi':
        return 'Uvicorn running on (https?://\\S+|[0-9]+)';

The reason we don't need a listener for the Gunicorn approach is that when debugging--which is the only time this code will be active--we'll always be using Uvicorn to launch (more on that next...)

3. Similar to Flask, rather than running the file, we have to run the Uvicorn module in the docker-run task, with arguments pointing to the entrypoint. So, instead of the task being this:

        {
            "type": "docker-run",
            "label": "docker-run: debug",
            "dependsOn": [
                "docker-build"
            ],
            "python": {
                "args": [
                    "--host",
                    "0.0.0.0",
                    "--port",
                    "8000"
                ],
                "file": "main.py"
            }
        }

It needs to be this:

        {
            "type": "docker-run",
            "label": "docker-run: debug",
            "dependsOn": [
                "docker-build"
            ],
            "python": {
                "args": [
                    "main:app",
                    "--host",
                    "0.0.0.0",
                    "--port",
                    "8000"
                ],
                "module": "uvicorn"
            }
        }

The code for generating this task is here, and it contains an example of how the Flask task gets some custom handling--you'd have something very similar, like:

// ... (the Flask code)
} else if (options.projectType === 'fastapi') {
    runOptions.args.unshift(`${path.basename(runOptions.file, '.py')}:app`); // Also, an `import * as path from 'path';` at the top

    runOptions.module = 'uvicorn';
    runOptions.file = undefined;
}

[Kludex]

I need to revert #2732 and fix it a different way. My bad!

I didn't understand this.

For the other points: got it! It's more clear now.
I'm going to apply those comments at some point between today and Sunday, jfyk.

I'll probably have to bother you to test it again after (if I can't fix the issue I mentioned above).

Thank you for the comments, @bwateratmsft !

[bwateratmsft]

I need to revert #2732 and fix it a different way. My bad!

I didn't understand this.

I introduced a bug with #2732 so I gotta fix it or debugging won't work. I have a PR now: #2741

UPDATE: #2741 is now done so all that's needed would be to merge into your fork.

[Kludex]

@bwateratmsft I've applied the changes. Thank you for the update @bwateratmsft :)

Unfortunately I still need to bother you with the testing 😢

[bwateratmsft]

@bwateratmsft I've applied the changes. Thank you for the update @bwateratmsft :)

Unfortunately I still need to bother you with the testing 😢

Worked like a charm! Didn't encounter any issues on either Window or Mac. Usually Mac means Linux works too, I'm not worried about it.

This is exciting! Thanks @Kludex!

[Kludex]

COOL! 🎉

@bwateratmsft Thanks for all the help! :)