Add support for --platform flag in docker-build task
#3874
Conversation
| @@ -52,6 +52,7 @@ | |||
| "vscode-docker.tasks.docker-build.dockerBuild.dockerfile": "Path to the Dockerfile used for the build.", | |||
| "vscode-docker.tasks.docker-build.dockerBuild.labels.description": "Labels applied to the Docker image used for debugging.", | |||
| "vscode-docker.tasks.docker-build.dockerBuild.labels.includeDefaults": "Whether to include the default set of labels defined by the Docker extension", | |||
| "vscode-docker.tasks.docker-build.dockerBuild.platform": "Target platform for the image build", | |||
There was a problem hiding this comment.
Does this option support just single platform, or is multi-platform build possible? Perhaps it is worth to clarify.
There was a problem hiding this comment.
Good question. I originally thought to do multiple since that's what I saw in examples, but upon closer inspection, that applies only to the docker buildx build command--not the regular docker build command, which only accepts a single platform option.
There was a problem hiding this comment.
Also, in tasks.json it will give a warning squiggle if you try to give an array instead of a single value.
There was a problem hiding this comment.
You are right @bwateratmsft. It is one step even more nuanced than that.
Behavior of buildx:
- Doesn't publish images to the image cache, by default.
- Only supports publishing images to the cache when a single platform is set.
AFAICT, the multi-platform option (which is awesome!) is intended for direct push to registry. That's what I've used it for. As a side-note, when used correctly, you end up with --pull --push together. I find that to be pretty funny each time I see it.
Closes #3870.