Read attach setting every time, plus update telemetry #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenWeatherford
force-pushed
the
saw/reload-attach-config
branch
from
2ae1b45 to
f476a16
Compare
ejizba
reviewed
Sep 10, 2018
commands/utils/docker-endpoint.ts
Outdated
| // tslint:disable-next-line:no-var-self | ||
| let me = this; | ||
| let engineType: DockerEngineType; | ||
| await callWithTelemetryAndErrorHandling('getEngineType', async function (this: IActionContext): Promise<void> { |
There was a problem hiding this comment.
What's the reasoning behind a separate telemetry event for this? Couldn't you just include properties.engineType in the existing telemetry for the two (as far as I can tell) commands calling this?
There was a problem hiding this comment.
Somehow seemed like a good idea at the time... :-)
ejizba
approved these changes
Sep 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #463