ACR-3.0.0 API upgrade #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dev to match Microsoft/vscode-docker/master
* Added Azure Credentials Manager Singleton * Added getResourceManagementClient
Added try catch loop and awaited for resource group list again to check for duplicates with ResourceManagementClient
* Added Azure Credentials Manager Singleton * Small Style Fixes * Further Style fixes, added getResourceManagementClient * Lazy Initialization Patches
-Changed order of questions asked to user for better UX (location of new res group & location of new registry) -Placeholder of location is display name view
Master update
Create Registry
* first fully functional version of delete through input bar AND right click * refactored code to make it prettier! * comments * comments, added subscription function * fixed to style guide * style fixes, refactoring * delete image after reviews put my functions from azureCredentialsManager into two new files: utils/azure/acrTools.ts, and commands/utils/quick-pick-azure.ts Edited code based on Esteban's and Bin's reviews * One last little change to delete image * moved repository, azureimage, and getsubscriptions to the correct places within deleteImage * changes from PR reviews on delete image * fixed authentication issue, got rid of azureAccount property for repository and image **on constructor for repository, azurecredentialsmanager was being recreated and thus couldn't find the azureAccount. For this reason, I got rid of the azureAccount property of the classes Repository and AzureImage. This bug may lead to future problems (Esteban and I couldn't see why it was happening) * minor fixes deleteImage * delete a parentheses
Master merge maintain fork updated
* Merge fixes to acquire latest telemetry items * Updated to master AzureUtilityManager
* tslint updates, transfered from old branch * updated icon * Addressed PR comments- mostly styling/code efficiency * Changed url to aka.ms link * changed Error window to Info message for no build tasks in your registry * Changed default sku and unified parsing resource group into a new method, getResourceGroup in acrTools.ts * Changed build task icon
…code-docker into Jackson/QuickBuildDev
* deleteRepo moved over to branch off dev * Got rid of unnecessary code, fully functioning! * deleteRepo moved over to branch off dev * Got rid of unnecessary code, fully functioning! * spacing * final commit * Cleaned code * Added Telemetry
Closed
rosanch
commented
Nov 2, 2018
|
FYI this PR was created before our recent switch from Travis CI to Azure Dev Ops. Push a commit (merging with master or addressing comments) and the "checks" for this PR will be updated |
rosanch
commented
Nov 3, 2018
Deletion of resizable.js Package.json commands alphabetically ordered. General typos, grammar and naming fixes. Change from fs - fs-extra. Other general improvments.
| @@ -9,112 +9,59 @@ import * as assert from 'assert'; | |||
| import * as path from 'path'; | |||
There was a problem hiding this comment.
Note to self: Re-review this file with full diff
Quick Build Image name and dockerFile selection Improvements. Upgrade from fs to fs-extra. Log table bug fixes. Error Handeling Improvements. Other general improvements.
loadLogs parameters update. uploadSourceCode Improvements.
|
I believe just two items left. |
rosanch
added a commit
to AzureCR/vscode-docker
that referenced
this pull request
Nov 9, 2018
Sync with Microsoft microsoft#506
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains the last features created by the interns during the summer and the update to the new ACR API