Use win-ca fallback logic since nAPI isn't currently compatible with Electron #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejizba
approved these changes
Jan 29, 2019
Turns out this is the permanent fix (at least for this version of win-ca). Updated comment. |
StephenWeatherford
added a commit
that referenced
this pull request
Jan 30, 2019
…Electron (#761) * Use win-ca fallback logic since nAPI isn't currently compatible with Electron * Add comment * comment
StephenWeatherford
added a commit
that referenced
this pull request
Jan 31, 2019
* Use win-ca fallback logic since nAPI isn't currently compatible with Electron (#761) * Use win-ca fallback logic since nAPI isn't currently compatible with Electron * Add comment * comment * Prepare for v0.5.2 hotfix release
StephenWeatherford
added a commit
that referenced
this pull request
Feb 7, 2019
* packag lock * Prepare for v0.5.2 hotfix release (#763) * Use win-ca fallback logic since nAPI isn't currently compatible with Electron (#761) * Use win-ca fallback logic since nAPI isn't currently compatible with Electron * Add comment * comment * Prepare for v0.5.2 hotfix release * Update version of win-ca to get fallback code (#780) * Update version of win-ca to get fallback code * package lock
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not positive if this is the correct fix (it might be), or just a work-around, but it does fix the issue, and we need a fix before vscode ships next week.
#733
Note that mac-ca works differently (spawns a mac exe) so does not have this same problem.