Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits based on customer feedback #2630

Merged
merged 1 commit into from
May 6, 2019
Merged

Edits based on customer feedback #2630

merged 1 commit into from
May 6, 2019

Conversation

@Chuxel Chuxel requested a review from gregvanl May 6, 2019 18:19
@@ -195,14 +195,33 @@ SSH can be strict about file permissions and if they are set incorrectly, you ma

### Local SSH file and folder permissions

#### macOS / Linux
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

H4s don't render very well on our site so I've been changing platform headers to bold text.

macOS / Linux:

I can update after the merge.

@gregvanl gregvanl merged commit 9ff656d into master May 6, 2019
@Chuxel
Copy link
Member Author

Chuxel commented May 6, 2019

@gregvanl Sounds good! Good to know - will do that in future updates.

@gregvanl
Copy link

gregvanl commented May 6, 2019

Published

@@ -143,7 +143,9 @@ If you clone a Git repository using SSH and your SSH key has a passphrase, VS Co

### Docker Extension limitations

The Docker extension is configured to run as a local "UI" extension that runs on the Windows side by default. This enables the extension to work with your local Docker installation when you are developing inside a container. However, some Docker commands invoked from the Docker extension can fail from a WSL window. If you want the Docker extension to interact with an installed Docker CLI in WSL instead, add the following to `settings.json`:
The Docker extension is configured to run as a local "UI" extension that runs on the Windows side by default. This enables the extension to work with your local Docker installation when you are developing in WSL or [inside a container](/docs/remote/containers.md) since the Docker CLI is not available by default in these environments. However, commands invoked from the Docker extension that rely on the Docker command line, for example **Docker: Show Logs**, fail.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍 I'll admit I did not actually test wsl remote yet, but I do have an understanding of WSL and Docker, so I must point something out or ask something here. The text mentions that the Docker extension is running locally. It also points out it thus uses/works with the local Docker installation. As such, in both WSL and container, why would Docker: Show Logs not work? Both are local after all.

I understand why this is not the case when working over ssh, there it requires special consideration since dockerd and docker CLI is run remotely, whereas the Docker extension is local by default.

@Chuxel Chuxel deleted the clantz/working-tree branch May 13, 2019 17:02
@adlermedrado
Copy link

+1 for microsoft/vscode-remote-release#116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants