Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove confusion about .NET Core Docker Config Deprication #3963

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

MarcusOy
Copy link
Contributor

In VSCode, creating a new launch config within launch.json with the template name Docker: .NET Core Attach (Preview) will create a config listed in the .NET Core section. I believe the quote saying "previous (Preview)" is deprecated is ambiguous, since the documentation doesn't say that the current version of the config available as a launch config template is still labeled as a preview. This let me to believe that the config I had added within my launch.json was the deprecated implementation.

I propose this simple change to clear up my original confusion.
See comment: microsoft/vscode-docker#2248 (comment)

In VSCode, creating a new launch config within launch.json with the template name Docker: .NET Core Attach (Preview) will create a config listed in the .NET Core section. I believe the quote saying "previous (Preview)" is deprecated is ambiguous, since the documentation doesn't say that the current version of the config available as a launch config template is still labeled as a preview. This let me to believe that the config I had added within my launch.json was the deprecated implementation.

I propose this simple change to clear up my original confusion.
See comment: microsoft/vscode-docker#2248 (comment)
@MarcusOy MarcusOy changed the title Remove confusion about .NET Core Deprication Remove confusion about .NET Core Docker Config Deprication Aug 26, 2020
@ghogen
Copy link
Collaborator

ghogen commented Sep 3, 2020

@BigMorty @karolz-ms Does this change look good to you?

@BigMorty
Copy link
Member

BigMorty commented Sep 3, 2020

Looks good to me. @bwateratmsft shouldn't we remove the "(preview)" label on the new debug config?

@bwateratmsft
Copy link
Contributor

bwateratmsft commented Sep 3, 2020

Looks good to me. @bwateratmsft shouldn't we remove the "(preview)" label on the new debug config?

@BigMorty I'm reluctant to because I feel the experience of getting the debugger into the container is still not good. If it's already downloaded on the host and volume mapped into the container it works reasonably well, but otherwise it must be copied in which involves annoying prompts and takes a lot of time.

I'd really like to consider producing a .NET dev-container-ish image that includes vsdbg built in. Unfortunately that would mean a pretty big bump in size...but I'd also like to see vsdbg get smaller. I think one of the focus points of .NET 5 is to make self-contained executables much smaller so that might solve that problem.

@BigMorty @karolz-ms Does this change look good to you?

Looks good to me too, thanks @MarcusOy!

@gregvanl gregvanl merged commit 52eb415 into microsoft:master Sep 3, 2020
@MarcusOy MarcusOy deleted the patch-1 branch September 3, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants