Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove debug configuration #169

Closed
vidorteg opened this issue Jun 16, 2020 · 0 comments · Fixed by #183
Closed

Remove debug configuration #169

vidorteg opened this issue Jun 16, 2020 · 0 comments · Fixed by #183
Labels
task Work that needs to be done

Comments

@vidorteg
Copy link
Contributor

Another step into the simplified contribution model is to remove debug configuration as it requires a chromium environment just to keep it updated and with the latest changes on the source zip file it is duplicating some verifications.
@vidorteg vidorteg added the task Work that needs to be done label Jun 16, 2020
@vidorteg vidorteg mentioned this issue Aug 4, 2020
Merged
@vidorteg vidorteg linked a pull request Aug 4, 2020 that will close this issue
Removing debug mode. #183
Merged
vidorteg added a commit that referenced this issue Aug 12, 2020
@vidorteg
Removing debug mode. (#183)
f0884e7 
Currently there is a configuration named "debug mode" which targets the source files of the Edge Chromium repo (not the output files). This was done to enable coding with the Devtools source files. Unfortunately this created a dependency to the source files itself (requiring the full 2gb file). This PR removes this dependency, any changes required on Devtools should be done in Devtools repo or patched through a "polyfill"

Addresses #169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task Work that needs to be done
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing debug mode. microsoft/vscode-edge-devtools
1 participant
@vidorteg