Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming Extension to "Microsoft Edge (Chromium) Tools for VSCode" + Changelog Update #134

Merged
merged 5 commits into from
May 8, 2020

Conversation

mliao95
Copy link

@mliao95 mliao95 commented May 1, 2020

With the addition of the Network tool from PR 128, the extension is being renamed from ""Elements for Microsoft Edge (Chromium)"" to "Microsoft Edge (Chromium) Tools for VSCode."

This PR targets the usages of the extension name in the README, config files, package.json and other files.

image

Renaming the official extension name to "Microsoft Edge (Chromium) Tools for VSCode"

Changelog update

​​​​​​​​​​​​​​

@mliao95 mliao95 requested review from codepo8 and vidorteg May 1, 2020 18:51
Copy link
Contributor

@vidorteg vidorteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is only one comment that needs to be addresses. Everything else LGTM.

package.json Outdated
"displayName": "Elements for Microsoft Edge (Chromium)",
"description": "Use the Microsoft Edge (Chromium) Elements tool from within VS Code to see your site's runtime HTML structure, alter its layout, and fix styling issues.",
"displayName": "Microsoft Edge (Chromium) Tools for VSCode",
"description": "Use the Microsoft Edge (Chromium) Tools from within VS Code to see your site's runtime HTML structure, alter its layout, fix styling issues as well as see your site's network requests.",
"version": "1.0.7",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"version": "1.0.8"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Changed, updated package-lock.json and checking in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename the extension
2 participants