Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing "headless" browser launch mode #185

Merged
merged 2 commits into from
Aug 6, 2020
Merged

Conversation

vidorteg
Copy link
Contributor

@vidorteg vidorteg commented Aug 5, 2020

This PR introduces a new Setting called:

  • Headless (off by default)

Which allow the user to use the extension in headless mode. The headless browser tabs will be closed when the associated visual studio code session ends.

Tests are also provided.

Demo:
https://imgur.com/a/qryItHH

Addresses:
#173

@vidorteg vidorteg requested a review from mliao95 August 5, 2020 22:15
@vidorteg vidorteg linked an issue Aug 5, 2020 that may be closed by this pull request
Copy link

@mliao95 mliao95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well! LGTM. Are we changing this to be the default option for the extension?

@vidorteg
Copy link
Contributor Author

vidorteg commented Aug 6, 2020

It works well! LGTM. Are we changing this to be the default option for the extension?

Not in this PR, but we can change that easily in the future :)

@vidorteg vidorteg merged commit cc88385 into master Aug 6, 2020
@vidorteg vidorteg deleted the vidal/headlessBrowser branch January 30, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the option to attach to headless browser
2 participants