[Settings - Themes]: Implementing dropdown in settings to change themes #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mliao95
changed the title
mliao95
force-pushed
the
user/milia/theme-settings
branch
from
8392e6d to
d57723e
Compare
vidorteg
reviewed
Oct 30, 2020
vidorteg
reviewed
Oct 30, 2020
mliao95
commented
Oct 30, 2020
| console.log('Theme =' + theme); | ||
| resolve(theme); | ||
| }); | ||
| }.bind(this)); |
There was a problem hiding this comment.
@vidorteg - I checked, and we do need this bind call to access the getThemes function
|
In the most recent patch, I did some things to clean up the code:
|
added 8 commits
October 30, 2020 13:20
mliao95
force-pushed
the
user/milia/theme-settings
branch
from
afa9438 to
7a5250b
Compare
vidorteg
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a settings dropdown to change the themes of the DevTools extension.
This PR also broadens the use of the settingsProvider (formerly tabSettingsProvider) to include the theme settings.
Closes #207