-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaned up README and added startpage #322
Conversation
This change cleans out the README of outdated and overly complicated information and adds new screencasts and screenshots instead. There's also a new optional startpage to show when opening the tools.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments.
@@ -109,45 +105,39 @@ Attach the extension to your live reloading project | |||
* Navigate in the browser of the extension to `localhost:8080/{file name you want to open}` | |||
* All changes that are saved in this folder now trigger a refresh | |||
|
|||
#### Opening source files from the Elements tool | |||
## Changing Extension Settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the screencast and changed the text accordingly.
README.md
Outdated
|
||
An example webpack configuration for sass and typescript is given below: | ||
You can enable the Network Pane to inspect any network request of the attached browser. To do this, change the setting and restart the extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: Network is enabled by default and this section gives the impression that it isn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed and removed the extra screencast
* `urlFilter`: A string that can contain wildcards that will be used for finding a browser target, for example, "localhost:*/app" will match either "http://localhost:123/app" or "http://localhost:456/app", but not "https://stackoverflow.com". This property will only be used if `url` and `file` are not specified. | ||
* `timeout`: The number of milliseconds that the Microsoft Edge Tools will keep trying to attach to the browser before timing out. Defaults to 10000ms. | ||
|
||
#### Sourcemaps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe move to a SourceMaps.md
file and reference it where necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
* Debug using a windowed or headless version of the Microsoft Edge Browser | ||
* Side Bar view for listing all the debuggable targets, including tabs, extensions, service workers, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a note, service and shared workers are hidden from the target list by default and can be enabled via settings. Up to you whether we want to publicize a disabled-by-default functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not for now, and maybe think about how we could make that more interesting. As we don't have the applications tab for debugging service workers it seems superfluous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The new pages look great! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
This change cleans out the README of outdated and overly complicated information and adds new screencasts and screenshots instead.
There's also a new optional startpage to show when opening the tools.