Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme detection for supported Devtools themes in frame hosted tools #455

Merged
merged 4 commits into from
Aug 16, 2021

Conversation

bgoddar
Copy link
Contributor

@bgoddar bgoddar commented Aug 12, 2021

This PR adds support for setting the devtools extension theme if the user switches to a theme that the devtools frontend supports

…s. fall back to light/dark/system preference. reload the devtools on change
Copy link
Member

@hkal hkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the approach. LGTM.

src/common/settingsProvider.ts Show resolved Hide resolved
@bgoddar bgoddar marked this pull request as ready for review August 13, 2021 16:25
@bgoddar bgoddar changed the title WIP: Add theme detection for supported Devtools themes Add theme detection for supported Devtools themes in frame hosted tools Aug 13, 2021
Copy link

@mliao95 mliao95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for setting this up.

@bgoddar bgoddar merged commit 9ef2338 into main Aug 16, 2021
@bgoddar bgoddar deleted the bgoddar/testThemeMigration branch August 16, 2021 17:40
@bgoddar bgoddar mentioned this pull request Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants