launch Microsoft Edge with specified args #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hkal
requested changes
Nov 10, 2021
There was a problem hiding this comment.
Thanks for the PR. The team is planning on generalizing passing browser cmdline switches so we don't have to add new extension settings for each one, since there are many. Can you update the PR to work with an extension setting like:
"browserArgs" : [
"--disable-web-security",
"--user-data-dir=/some/custom/path"
]
added 2 commits
November 10, 2021 15:47
gp5251
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to enable cors when launching instance.