Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine prompt informing users of errors #807

Merged
merged 3 commits into from
Jan 24, 2022

Conversation

antross
Copy link
Contributor

@antross antross commented Jan 11, 2022

Use a warning as some issues may be transient. Also suggest
checking settings as we've seen some issues are due to
misconfiguration of the extension. Lastly, direct users to a
search of existing issues with the same error message to
discourage filing duplicates.

Example:
image

Use a warning as some issues may be transient. Also suggest checking settings as we've seen some issues are due to
misconfiguration of the extension. Lastly, direct users to a
search of existing issues with the same error message to
discourage filing duplicates.
@antross antross requested review from hkal and mliao95 January 11, 2022 17:51
@mliao95
Copy link

mliao95 commented Jan 18, 2022

Generally, LGTM.

One suggestion would be to narrow down the relevant settings for that specific error with more filter terms if possible. I'm thinking something like this:
image

Also as an FYI, I was having trouble getting openInEditor working in Canary. Getting this error:
image
Uncaught (in promise) TypeError: Failed to fetch dynamically imported module: https://devtools.azureedge.net/serve_file/@66ea0911636d0b996e4bdf70c832ed0984310f32/entrypoints/vscode_app/VSCodeHost.js

Could you see if you're hitting this as well?

Copy link

@mliao95 mliao95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestion above

@antross
Copy link
Contributor Author

antross commented Jan 24, 2022

I'd like to hold-off on error-specific scoped settings search for now. Not sure the incremental gain is worth the additional work at the moment (curious to see if folks have trouble finding the correct settings once we put this out there).

@antross antross merged commit 27770df into microsoft:main Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants