Fix Min-Browser Version Comparison #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a bug with the version comparison logic used to determine which revision of the DevTools frontend to fetch from the CDN. The previous version comparison logic did not appropriately cast to int the product could get into a situation where browser version "100" > min_ver.
antross
approved these changes
Feb 16, 2022
mliao95
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a bug with the version comparison logic used to
determine which revision of the DevTools frontend to fetch from the CDN.
The previous version comparison logic did not appropriately cast to int
the product could get into a situation where browser version "100" > min_ver.
Fixes #878