[LaunchConfigManager]: Improve logic for configuring existing launch.json #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antross
suggested changes
Mar 31, 2022
antross
approved these changes
Apr 4, 2022
antross
pushed a commit
that referenced
this pull request
Apr 5, 2022
…json (#945) * [LaunchConfigManager]: Improve logic for configuring existing launch.json * handle duplicate names + increase test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
launch.jsonfiles would result in either duplicate or missing entries.Changes:
launch.jsonconfiguration with our expected configurations. This allows us to add only the missing configs.launch.jsonconfiguration is supported or not unsupported.Things to test:
Configure launch.jsonagainst variouslaunch.jsonfiles.launch.json,launch.jsonwith some of the configurations,launch.jsonwith none of the configurations, etc.launch.jsonfiles, see which ones generate theConfigure launch.jsonbutton. Assuming that all of the extension configs exist, this button shouldn't show up.