added severity off to customizations setting (#1243)

microsoft · May 14, 2021 · 2e04670 · 2e04670
1 parent 2e0e525
commit 2e04670
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 2 deletions.
diff --git a/client/src/extension.ts b/client/src/extension.ts
@@ -186,6 +186,7 @@ enum RuleSeverity {
 	info = 'info',
 	warn = 'warn',
 	error = 'error',
+	off = 'off',
 
 	// Added severity override changes
 	default = 'default',

diff --git a/package.json b/package.json
@@ -392,7 +392,8 @@
 									"info",
 									"default",
 									"upgrade",
-									"warn"
+									"warn",
+									"off"
 								],
 								"type": "string"
 							},

diff --git a/playgrounds/6.0/.eslintrc.json b/playgrounds/6.0/.eslintrc.json
@@ -13,6 +13,7 @@
         "sourceType": "module"
     },
     "rules": {
+        "no-use-before-define": "error",
         "no-useless-escape": "error",
         "no-const-assign": "warn",
         "no-this-before-super": "warn",

diff --git a/playgrounds/6.0/.vscode/settings.json b/playgrounds/6.0/.vscode/settings.json
@@ -44,7 +44,8 @@
 		{ "rule": "!no-*", "severity": "upgrade" },
 		{ "rule": "*console*", "severity": "upgrade" },
 		{ "rule": "*semi*", "severity": "default" },
-		{ "rule": "radix", "severity": "default" }
+		{ "rule": "radix", "severity": "default" },
+		{ "rule": "no-use-before-define", "severity": "off" }
 	],
 	"editor.codeActionsOnSaveTimeout": 2000,
 	"eslint.format.enable": true,

diff --git a/server/src/eslintServer.ts b/server/src/eslintServer.ts
@@ -515,6 +515,7 @@ function recordCodeAction(document: TextDocument, diagnostic: Diagnostic, proble
 
 function adjustSeverityForOverride(severity: number | RuleSeverity, severityOverride?: RuleSeverity) {
 	switch (severityOverride) {
+		case RuleSeverity.off:
 		case RuleSeverity.info:
 		case RuleSeverity.warn:
 		case RuleSeverity.error:
@@ -1404,6 +1405,11 @@ function validate(document: TextDocument, settings: TextDocumentSettings & { lib
 			if (docReport.messages && Array.isArray(docReport.messages)) {
 				docReport.messages.forEach((problem) => {
 					if (problem) {
+						const isOff = getSeverityOverride(problem.ruleId, settings.rulesCustomizations) === RuleSeverity.off;
+						if (isOff) {
+							// Filter out rules with severity override to off
+							return;
+						}
 						const isWarning = convertSeverityToDiagnostic(problem.severity) === DiagnosticSeverity.Warning;
 						if (settings.quiet && isWarning) {
 							// Filter out warnings when quiet mode is enabled
-Original file line number
+Diff line change
@@ Expand Up / @@ -392,7 +392,8 @@ @@
     									"info",
     									"default",
     									"upgrade",
-    									"warn"
+    									"warn",
+    									"off"
     								],
     								"type": "string"
     							},
@@ Expand Down @@